Skip to content

Step and anchor step readonly behavior#2913

Merged
rajsite merged 12 commits intomainfrom
step-readonly
Apr 2, 2026
Merged

Step and anchor step readonly behavior#2913
rajsite merged 12 commits intomainfrom
step-readonly

Conversation

@rajsite
Copy link
Copy Markdown
Member

@rajsite rajsite commented Apr 1, 2026

Pull Request

🤨 Rationale

Implement readonly state for the step and anchor step. Implements the new readonly styling discussed in #2879 of showing focus state on keyboard interactions (and not active / hover states).

👩‍💻 Implementation

  • Implement readonly visual, i.e. the only interaction states are default and focusVisible.
    • Leveraged the revert-layer css feature within active and hover layers to undo them for the readonly state
  • Implement readonly behavior by catching click event from the underlying button / anchor and stopping propagation & preventing default action

🧪 Testing

  • Added to matrix tests and interactions matrix tests. Required splitting the matrix and followed patterns elsewhere of splitting on theme and manipulation states
  • Added tests for verifying click event in disabled and readonly

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed. Enabled readonly docs in storybook.

@rajsite rajsite marked this pull request as ready for review April 2, 2026 15:50
@rajsite rajsite requested a review from jattasNI as a code owner April 2, 2026 15:50
@rajsite
Copy link
Copy Markdown
Member Author

rajsite commented Apr 2, 2026

@mollykreis could you review the changes for adding step readonly behavior in Jesse's absense?

@rajsite rajsite requested a review from mollykreis April 2, 2026 16:05
@rajsite rajsite merged commit cf19bdf into main Apr 2, 2026
11 checks passed
@rajsite rajsite deleted the step-readonly branch April 2, 2026 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants